Re: [Xen-devel] [PATCH 1/5] make: simplify setting HOST{CC/CXX}

[Jan Beulich <JBeulich@xxxxxxxx>]

 >>> On 26.06.19 at 15:55, <roger.pau@xxxxxxxxxx> wrote:
 > --- a/Config.mk
 > +++ b/Config.mk
 > @@ -39,22 +39,12 @@ DESTDIR     ?= /
 >  # Allow phony attribute to be listed as dependency rather than fake 
target
 >  .PHONY: .phony
 >
 > -# If we are not cross-compiling, default HOSTC{C/XX} to C{C/XX}
 > -ifeq ($(XEN_TARGET_ARCH), $(XEN_COMPILE_ARCH))
 > -HOSTCC ?= $(CC)
 > -HOSTCXX ?= $(CXX)
 > -endif
 > -
 >  # Use Clang/LLVM instead of GCC?
 >  clang ?= n
 >  ifeq ($(clang),n)
 >  gcc := y
 > -HOSTCC ?= gcc
 > -HOSTCXX ?= g++
 >  else
 >  gcc := n
 > -HOSTCC ?= clang
 > -HOSTCXX ?= clang++
 >  endif

The inclusion point leading to config/StdGNU.mk sits below
here afaict, so I don't see how ...

 > --- a/config/StdGNU.mk
 > +++ b/config/StdGNU.mk
 > @@ -9,6 +9,10 @@ CC        ?= $(CROSS_COMPILE)gcc
 >  CXX       ?= $(CROSS_COMPILE)g++
 >  LD_LTO    ?= $(CROSS_COMPILE)ld
 >  endif
 > +
 > +HOSTCC    ?= $(CC)
 > +HOSTCXX   ?= $(CXX)

... these are every going to take effect - the two variables aren't
unset anymore at that point. Furthermore, when CROSS_COMPILE
is not empty, this is certainly not what we want.

Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel