Re: [Xen-devel] [PATCH 3/4] xen/link: Fold .data.read_mostly into .data

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 19.06.19 at 22:11, <andrew.cooper3@xxxxxxxxxx> wrote:
> .data.read_mostly only needs separating from adjacent data by one cache line
> to be effective, and placing it adjacent to .data.page_aligned fulfills this
> requirement.
> 
> For ARM, .ex_table appears to be a vestigial remnant.  Nothing in the
> resulting build ever inspects or acts on the contents of the table.  The arm32
> build does however have some assembly routines which fill .ex_table.
> 
> Drop all of ARM's .ex_table infrastructure, to reduce the size of the compiled
> binary, and avoid giving the illusion of exception handling working.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Without you undoing part of 01fe4da624 ("x86: force suitable
alignment in sources rather than in linker script"), i.e. with the
ALIGN(PAGE_SIZE) dropped, x86 part
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Yet FTR - I don't think there was anything wrong with it having its own
section in the final binary. Of course there's also nothing wrong with it
getting folded into .data, in particular with it sitting ahead of
.data.page_aligned anyway.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel