Re: [Xen-devel] [PATCH 4/4] xen/link: Misc cleanup

[Julien Grall <julien.grall@xxxxxxx>]

Hi Andrew,

On 6/19/19 10:38 PM, Andrew Cooper wrote:
> On 19/06/2019 22:30, Julien Grall wrote:
> > Hi,
> >
> > On 6/19/19 9:11 PM, Andrew Cooper wrote:
> > >    * Drop .gnu.warning.  Xen, not being a library, has no need for
> > >      __attribute__((__warning__("str"))) and isn't liable to ever gain
> > > such
> > >      annotations for link time warnings.
> > What if this is introduced?
> Then attempting to link Xen as a library against another object file
> won't emit the custom linker warning.
Ok, so it is not like Xen will crash.

> Its main use is for phase-out of problematic API's, but for Xen (and
> other standalone binaries) we do that by replacing problematic functions
> entirely.
> > How do we catch it?
> Code review?
I usually quite like when the tools help us to catch such issue :).

Anyway, as this is not overly critical:

Acked-by: Julien Grall <julien.grall@xxxxxxx>

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel