Re: [Xen-devel] [PATCH v3 07/13] pci: switch pci_conf_read8 to use pci_sbdf_t

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 07.06.19 at 11:22, <roger.pau@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/cpu/amd.c
> +++ b/xen/arch/x86/cpu/amd.c
> @@ -420,12 +420,12 @@ static void disable_c1_ramping(void)
>       nr_nodes = ((pci_conf_read32(0, 0, 0x18, 0x0, 0x60)>>4)&0x07)+1;
>       for (node = 0; node < nr_nodes; node++) {
>               /* PMM7: bus=0, dev=0x18+node, function=0x3, register=0x87. */
> -             pmm7 = pci_conf_read8(0, 0, 0x18+node, 0x3, 0x87);
> +             pmm7 = pci_conf_read8(PCI_SBDF(0, 0, 0x18 + node, 3), 0x87);

You drop a pointless 0x here, but ...

>               /* Invalid read means we've updated every Northbridge. */
>               if (pmm7 == 0xFF)
>                       break;
>               pmm7 &= 0xFC; /* clear pmm7[1:0] */
> -             pci_conf_write8(0, 0, 0x18+node, 0x3, 0x87, pmm7);
> +             pci_conf_write8(0, 0, 0x18 + node, 0x3, 0x87, pmm7);

... you leave one in place here - is this intentional? (Of course that's
easy enough to adjust while committing.) Anyway,
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel