Re: [Xen-devel] [PATCH v1] stubdom/vtpm: include stdio.h for declaration of printf

[Olaf Hering <olaf@xxxxxxxxx>]

Please review this patch.

Am Tue, 29 May 2018 14:06:48 +0200
schrieb Olaf Hering <olaf@xxxxxxxxx>:

> The function read_vtpmblk uses printf(3), but stdio.h is not included
> in this file. This results in a warning from gcc-7:
> 
> vtpmblk.c: In function 'read_vtpmblk':
> vtpmblk.c:322:7: warning: implicit declaration of function 'printf' 
> [-Wimplicit-function-declaration]
>        printf("Expected: ");
> vtpmblk.c:322:7: warning: incompatible implicit declaration of built-in 
> function 'printf'
> vtpmblk.c:322:7: note: include '<stdio.h>' or provide a declaration of 
> 'printf'
> 
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> ---
>  stubdom/vtpm/vtpmblk.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/stubdom/vtpm/vtpmblk.c b/stubdom/vtpm/vtpmblk.c
> index fe529ab5ac..681f0c01b6 100644
> --- a/stubdom/vtpm/vtpmblk.c
> +++ b/stubdom/vtpm/vtpmblk.c
> @@ -20,6 +20,7 @@
>  #include <unistd.h>
>  #include <errno.h>
>  #include <fcntl.h>
> +#include <stdio.h>
>  
>  /*Encryption key and block sizes */
>  #define BLKSZ 16

Attachment: pgpQro_BBemsW.pgp
Description: Digitale Signatur von OpenPGP

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel