[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 03/60] xen/sched: let sched_switch_sched() return new lock address



On Wed, 2019-06-12 at 10:06 +0200, Juergen Gross wrote:
> On 12.06.19 09:40, Jan Beulich wrote:
> > > > > On 11.06.19 at 18:55, <dfaggioli@xxxxxxxx> wrote:
> > > On Tue, 2019-05-28 at 12:32 +0200, Juergen Gross wrote:
> > > > Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> > > > 
> > > Reviewed-by: Dario Faggioli <dfaggioli@xxxxxxxx>
> > > 
> > > I'm wondering whether it make sense for the above to be quickly
> > > mentioned in the changelog, but am leaning toward "not really
> > > necessary". In particular, I don't think it's worth to respin the
> > > patch
> > > just for that... So, either just something that can be added
> > > while
> > > committing, or forget it.
> > 
> > I'd be happy to add something while committing, but one of you
> > would need to propose the wording of this "something".
> 
> What about:
> 
> It should be noted that in credit2 the lock used to be set while
> still
> holding the global scheduler write lock, which will no longer be true
> with the new scheme applied. This is actually no problem as the write
> lock is meant to guard the call of init_pdata() which still is true.
> 
I'm ok with this.

Thanks (to both) and Regards
-- 
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.