[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen/scheduler: remove 'name' from 'struct scheduler'




On 6/11/19 18:04, George Dunlap wrote:
On 6/11/19 2:35 AM, Baodong Chen wrote:
'struct scheduler' already has member 'opt_name' and 'sched_id',
thus 'name' is a little redundant, so remove it.

Signed-off-by: Baodong Chen <chenbaodong@xxxxxxxxxx>
It's not redundant; one is a longer-form human-readable description,
another is a shorthand "option" description.

You can't be saving more than what, 500 bytes here?  I understand you're
trying to cut things down as small as you can, but this seems a bit
excessive.

Hello George,

Roger that.

I thought besides 'name', both 'opt_name' and 'sched_id' can identify

the scheduler and the 'name' mainly used in logs, thus can be removed.

As your suggestion, can leave it as it is.

  -George
.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.