Re: [Xen-devel] [PATCH] xen/arm: vtimer: fix return value to void for virt_timer_[save|restore]

[Julien Grall <julien.grall@xxxxxxx>]

On 11/06/2019 01:06, chenbaodong wrote:
> On 6/11/19 04:16, Julien Grall wrote:
> > Hi,
> >
> > NIT: I would use "change" instead of "fix". I feel "fix" is more when there 
> > are an actual bug.
> Sound good to me.
> > On 6/10/19 6:07 AM, Baodong Chen wrote:
> > > The original type is int and not used at all so fix to void.
> > The commit message is a bit unclear, you mention the type whereas the key 
> > point is none of the callers are using the return value. So how about:
> > "virt_timer_{save, return} always return 0 and none of the caller actually 
> > check it. So change the return type to void."
> > If you are happy with it, I can make the modifications them on commit.
> happy with it, please.
Committed, thank you!

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel