Re: [Xen-devel] [PATCH qemu-xen 4.10 & 4.11] xen_disk: Disable file locking for the PV disk backend

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Thu, May 23, 2019 at 10:41:48AM +0100, Anthony PERARD wrote:
> On Wed, May 22, 2019 at 07:54:42PM +0200, Olaf Hering wrote:
> > Am Wed, 22 May 2019 15:51:40 +0100
> > schrieb Anthony PERARD <anthony.perard@xxxxxxxxxx>:
> > 
> > > Can you give it a try with one of the affected qemu? (qemu-xen-4.10 or
> > > qemu-xen-4.11)
> > 
> > Thanks for the patch. Unfortunately there is no easy way to trigger the 
> > race.
> > Is the changed code path also exercised for PV domUs?
> 
> Yes! The code path is executed every time a disk is attached via the
> qdisk backend. So as long as guest can access the pv disk, then it's
> fine (for both HVM and PV domUs, and PVH).
> 
> Another way to make sure that the locking is disable is to attach a disk
> to a second guest, qemu should not complain anymore. I've tested both
> "raw" disk and "qcow2" disk but I'm not sure if other kind of disk needs
> to be tested.

Olaf, did you apply this patch and run some guest? Do they still boot?
It doesn't matter if you can't trigger the race with or without this
patch, I just want to know if there are any regression.
So, may have I your "Tested-by" ? And I will try to apply it to our
qemu-xen branches.

Thanks,

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel