Re: [Xen-devel] [PATCH v1] xen: make tracebuffer configurable

[chenbaodong <chenbaodong@xxxxxxxxxx>]

On 6/4/19 15:10, Jan Beulich wrote:
> > > > On 04.06.19 at 02:44, <chenbaodong@xxxxxxxxxx> wrote:
> > --- a/xen/include/xen/trace.h
> > +++ b/xen/include/xen/trace.h
> > @@ -21,12 +21,15 @@
> >   #ifndef __XEN_TRACE_H__
> >   #define __XEN_TRACE_H__
> >   
> > +#ifdef CONFIG_TRACEBUFFER
> >   extern int tb_init_done;
> > +#endif
> If this is to stay up here (which I'm still not sure it needs to; I had
> merely indicated that there likely is a reason for this without actually
> knowing what that reason might be), then I think the #define needs
> to go here as well, in an #else.
Yes, need to stay here because 'tb_init_done' used in 'asm-x86/trace.h'

which included  by 'xen/trace.h'  at line 32: #include <asm/trace.h>

will be fixed in next version.

> > @@ -47,6 +50,20 @@ static inline void trace_var(u32 event, int cycles, int 
> > extra,
> >   void __trace_hypercall(uint32_t event, unsigned long op,
> >                          const xen_ulong_t *args);
> >   
> > +#else
> > +#define tb_init_done false
> > +static inline void init_trace_bufs(void) {}
> > +static inline int tb_control(struct xen_sysctl_tbuf_op *tbc) { return -ENOSYS; 
> > }
> -EOPNOTSUPP
>
> Jan
>
>
> .
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel