Re: [Xen-devel] [PATCH 2/5] xen/vm-event: Expand vm_event_* spinlock macros and rename the lock

[Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>]

On 6/3/19 3:25 PM, Andrew Cooper wrote:
> These serve no purpose, but to add to the congnitive load of following
> the code.  Remove the level of indirection.
>
> Furthermore, the lock protects all data in vm_event_domain, making
> ring_lock a poor choice of name.
>
> For vm_event_get_response() and vm_event_grab_slot(), fold the exit
> paths to have a single unlock, as the compiler can't make this
> optimisation itself.
>
> No functional change.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Acked-by: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>


Thanks,
Razvan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel