Re: [Xen-devel] [PATCH] xen: debug_registers_trap, perf_counters_trap, and "static_partitioning"

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 01.06.19 at 01:00, <sstabellini@xxxxxxxxxx> wrote:
> --- a/xen/arch/arm/traps.c
> +++ b/xen/arch/arm/traps.c
> @@ -118,6 +118,28 @@ static int __init parse_vwfi(const char *s)
>  }
>  custom_param("vwfi", parse_vwfi);
>  
> +static bool debug_registers_trap = true;
> +static bool perf_counters_trap = true;
> +
> +static int __init opt_static_partitioning(const char *s)
> +{
> +    if ( strcmp(s, "true") && 
> +         strcmp(s, "True") &&
> +         strcmp(s, "1") )
> +        return 0;
> +
> +    vwfi = NATIVE;
> +    debug_registers_trap = false;
> +    perf_counters_trap = false;
> +    memcpy(opt_sched, "null", 5);
> +
> +    /* Disable Trap Debug and Performance Monitor now for CPU0 */
> +    WRITE_SYSREG(HDCR_TDRA, MDCR_EL2);
> +
> +    return 0;
> +}
> +custom_param("static_partitioning", opt_static_partitioning);

Please no underscores anymore in new option names, at least until
we perhaps implement string comparison to treat underscore and
dash as matching up.

> --- a/xen/common/schedule.c
> +++ b/xen/common/schedule.c
> @@ -39,7 +39,7 @@
>  #include <xen/err.h>
>  
>  /* opt_sched: scheduler - default to configured value */
> -static char __initdata opt_sched[10] = CONFIG_SCHED_DEFAULT;
> +char __initdata opt_sched[10] = CONFIG_SCHED_DEFAULT;
>  string_param("sched", opt_sched);
>  
>  /* if sched_smt_power_savings is set,
> --- a/xen/include/xen/sched.h
> +++ b/xen/include/xen/sched.h
> @@ -906,6 +906,7 @@ static inline bool is_vcpu_online(const struct vcpu *v)
>  }
>  
>  extern bool sched_smt_power_savings;
> +extern char opt_sched[10];

This, imo, is a layering violation, and hence should be solved in a
different way.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel