Re: [Xen-devel] [PATCH 1/2] adjust special domain creation (and call it earlier on x86)

[Julien Grall <julien.grall@xxxxxxx>]

Hi Jan,

The Arm code looks good to me. I have few comments regarding the common 
changes.
On 5/31/19 10:35 AM, Jan Beulich wrote:
> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -71,6 +71,11 @@ domid_t hardware_domid __read_mostly;
>   integer_param("hardware_dom", hardware_domid);
>   #endif
>   
> +/* Private domain structs for DOMID_XEN, DOMID_IO, etc. */
> +struct domain *__read_mostly dom_xen;
> +struct domain *__read_mostly dom_io;
> +struct domain *__read_mostly dom_cow;
The __read_mostly makes sense here, however please mention it in the 
commit message.
[...]

> --- a/xen/include/asm-x86/mm.h
> +++ b/xen/include/asm-x86/mm.h
> @@ -595,8 +595,6 @@ unsigned int domain_clamp_alloc_bitsize(
>   
>   unsigned long domain_get_maximum_gpfn(struct domain *d);
>   
> -extern struct domain *dom_xen, *dom_io, *dom_cow;	/* for vmcoreinfo */
> -
>   /* Definition of an mm lock: spinlock with extra fields for debugging */
>   typedef struct mm_lock {
>       spinlock_t         lock;
> --- a/xen/include/xen/domain.h
> +++ b/xen/include/xen/domain.h
> @@ -5,6 +5,7 @@
>   #include <xen/types.h>
>   
>   #include <public/xen.h>
> +
Without an explanation in the commit message, this looks like a spurious 
change.
>   #include <asm/domain.h>
>   #include <asm/numa.h>
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel