Re: [Xen-devel] [PATCH MM-PART2 RESEND v2 04/19] xen/arm: Rework HSCTLR_BASE

[Andrii Anisov <andrii.anisov@xxxxxxxxx>]

On 21.05.19 13:09, Julien Grall wrote:
> Hi,
>
> On 5/20/19 11:56 PM, Stefano Stabellini wrote:
> > On Tue, 14 May 2019, Julien Grall wrote:
> > > The current value of HSCTLR_BASE for Arm64 is pretty wrong. It would
> > > actually turn on SCTLR_EL2.nAA (bit 6) on hardware implementing
> > > ARMv8.4-LSE.
> > >
> > > Furthermore, the documentation of what is cleared/set in SCTLR_EL2 is
> > > also not correct and looks like to be a verbatim copy from Arm32.
> > >
> > > HSCTLR_BASE is replaced with a bunch of per-architecture new defines
> > > helping to understand better what is the initialie value for
> s/initialie/initial/
>
> > > Lastly, the documentation is dropped from arm{32,64}/head.S as it would
> > > be pretty easy to get out-of-sync with the definitions.
> > >
> > > Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
FWIW, with misprint fixed

Reviewed-by: Andrii Anisov <andrii_anisov@xxxxxxxx>

--
Sincerely,
Andrii Anisov.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel