Re: [Xen-devel] libxl assertion failure when creating any kind of guest

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 22.05.19 at 09:25, <olaf@xxxxxxxxx> wrote:
> Am Wed, 22 May 2019 01:11:54 -0600
> schrieb "Jan Beulich" <JBeulich@xxxxxxxx>:
> 
>> libxl__domain_build_info_setdefault (gc=0x7fffffffdee0, 
> b_info=0x7fffffffdb80)
>>     at libxl_create.c:143
> 
> This is libxl_defbool_val(b_info->device_model_stubdomain).
> 
> Due to the lack of a proper way to describe all the dependencies within
> libxl I suggest to revert these commits for the time being:
> 
> 278c64519c libxl: fix libxl_domain_need_memory after 899433f149d
> 899433f149 libxl: fix migration of PV and PVH domUs with and without qemu
> 3802ecbaa9 libxl: add helper function to set device_model_version

Well, the alternative is the one line change below.

Jan

libxl: further fix libxl_domain_need_memory() after 899433f149d

Besides providing a device_model_version setting (as done by 278c64519c
["libxl: fix libxl_domain_need_memory after 899433f149d"]), one is also
needed for device_model_stubdomain, or else the respective assert() in
libxl_defbool_val() (called from libxl__domain_build_info_setdefault())
will trigger.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

--- unstable.orig/tools/libxl/libxl_mem.c
+++ unstable/tools/libxl/libxl_mem.c
@@ -472,6 +472,7 @@ int libxl_domain_need_memory(libxl_ctx *
      * calculation doesn't really care which QEMU is set here, so we
      * go with the upstream default.
      */
+    libxl_defbool_setdefault(&b_info->device_model_stubdomain, false);
     if (!b_info->device_model_version)
         b_info->device_model_version = LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN;
 




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel