[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 12/14] xen/x86: pv: Convert update_intpte() to use typesafe MFN
On 10/05/2019 13:54, Jan Beulich wrote:
On 07.05.19 at 17:14, <julien.grall@xxxxxxx> wrote:
@@ -2177,8 +2177,8 @@ static int mod_l1_entry(l1_pgentry_t *pl1e, l1_pgentry_t
nl1e,
}
else if ( pv_l1tf_check_l1e(pt_dom, nl1e) )
return -ERESTART;
- else if ( unlikely(!UPDATE_ENTRY(l1, pl1e, ol1e, nl1e, gl1mfn, pt_vcpu,
- preserve_ad)) )
+ else if ( unlikely(!UPDATE_ENTRY(l1, pl1e, ol1e, nl1e, gl1mfn,
+ pt_vcpu, preserve_ad)) )
Stray change?
Yes, I will fix it.
@@ -3939,15 +3940,15 @@ long do_mmu_update(
*/
if ( (page->u.inuse.type_info & PGT_count_mask) >
(1 + !!(page->u.inuse.type_info & PGT_pinned) +
- (pagetable_get_pfn(curr->arch.guest_table_user)
==
- mfn) + local_in_use) )
+
(mfn_eq(pagetable_get_mfn(curr->arch.guest_table_user),
+ mfn)) + local_in_use) )
There's a stray pair of parentheses now left around a function call.
Ok.
--- a/xen/arch/x86/pv/mm.h
+++ b/xen/arch/x86/pv/mm.h
@@ -37,7 +37,7 @@ static inline l1_pgentry_t guest_get_eff_l1e(unsigned long
linear)
* Returns false for failure (pointer not valid), true for success.
*/
static inline bool update_intpte(intpte_t *p, intpte_t old, intpte_t new,
- unsigned long mfn, struct vcpu *v,
+ mfn_t mfn, struct vcpu *v,
bool preserve_ad)
Would you mind re-flowing this, as the last parameter declaration now
fits on the earlier line?
Ok.
With at least the former two taken care of
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Thank you.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
