[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 06/12] xen/arm: mm: Sanity check any update of Xen page tables



Hello Julien,

On 06.05.19 20:01, Julien Grall wrote:
It is not unrelated, the patch is necessary to make this patch works. Otherwise 
you will hit the ASSERT(mfn_eq(mfn, INVALID_MFN)) after one iteration.

I'm definitely not saying it is totally odd here. I'm just express my opinion 
that patches with flags introduction and implementation better go one after 
another.
But for sure this comment is a minor note, so it's up to you:)

BTW, with the fixed condition:

Reviewed-by: Andrii Anisov <andrii_anisov@xxxxxxxx>

--
Sincerely,
Andrii Anisov.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.