Re: [Xen-devel] [PATCH] xen/timers: Fix memory leak with cpu unplug/plug (take 2)

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 23.04.19 at 17:49, <andrew.cooper3@xxxxxxxxxx> wrote:
> Previous attempts to fix this leak failed to identify the root cause, and
> ultimately failed.  The cause is the CPU_UP_PREPARE case (re)initialising
> ts->heap back to dummy_heap, which leaks the previous allocation.
> 
> Rearrange the logic to only initialise ts once.  This also avoids the
> redundant (but benign, due to ts->inactive always being empty) initialising of
> the other ts fields.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel