[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/2] core-parking: interact with runtime SMT-disabling



>>> On 11.04.19 at 21:06, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 11/04/2019 13:45, Jan Beulich wrote:
>> When disabling SMT at runtime, secondary threads should no longer be
>> candidates for bringing back up in response to _PUD ACPI events. Purge
>> them from the tracking array.
>>
>> Doing so involves adding locking to guard accounting data in the core
>> parking code. While adding the declaration for the lock take the liberty
>> to drop two unnecessary forward function declarations.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> I can certainly appreciate these arguments, but surely the converse is
> true.  When SMT-enable is used, the newly-onlined threads are now
> eligible to be parked.

And nothing will keep them from getting parked.

> At the moment, this looks asymetric.

It does, but that's a result of core_parking.c only recording CPUs
it has parked, not ones it could park.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.