Re: [Xen-devel] [PATCH] x86/msr: Fix fallout from mostly c/s 832c180

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Apr 09, 2019 at 06:53:47PM +0100, Andrew Cooper wrote:
> The series 832c1803^..f61685a6 was committed without adequate review.
> 
>  * Fix the shim build by providing a !CONFIG_HVM declaration for
>    hvm_get_guest_bndcfgs()
>  * Revert the bogus de-const'ing of the vcpu pointer in
>    vmx_get_guest_bndcfgs().  vmx_vmcs_enter() really does mutate the vcpu, and
>    may cause it to undergo a full de/reschedule, which is in violation of the
>    ABI described by hvm_get_guest_bndcfgs().  guest_rdmsr() was always going
>    to need to lose its const parameter, and this was the correct time for it
>    to happen.

Enlighten me -- why does guest_rdmsr need to lose its const parameter?

This reads as if the code was buggy from the get-go.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel