Re: [Xen-devel] [PATCH RFC 07/55] x86/mm: add an end_of_loop label in map_pages_to_xen

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.04.19 at 14:22, <wei.liu2@xxxxxxxxxx> wrote:
> On Fri, Mar 15, 2019 at 09:40:39AM -0600, Jan Beulich wrote:
>> >>> On 07.02.19 at 17:44, <wei.liu2@xxxxxxxxxx> wrote:
>> > We will soon need to clean up mappings whenever the out most loop is
>> > ended. Add a new label and turn relevant continue's into goto's.
>> 
>> To be honest, I was on the edge of already suggesting less use
>> of goto in the previous patch. This one definitely goes too far
>> for my taste - I can somehow live with goto-s used for error
>> handling, but please not much more. Is there really no better
>> way?
>> 
> 
> It may be possible to call UNMAP at the beginning of the loop instead.
> How does that sound to you?

I think that's going to be better.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel