Re: [Xen-devel] [PATCH v4 01/15] x86/cpu: Create Hygon Dhyana architecture support file

[Pu Wen <puwen@xxxxxxxx>]

On 2019/4/3 18:22, Jan Beulich wrote:
> On 03.04.19 at 12:05, <puwen@xxxxxxxx> wrote:
> > I'm a little confused about which style to follow? In v3 series I
> > followed the style of the derived code. But in other patch you told me
> > to follow the Xen coding style, so in v4 series I changed the style to
> > match the bracing section of CODING_STYLE.
> Well, taking just the brace placement part doesn't make this
> the file Xen style. In my earlier response to that style
> question I did suggest you switch to Xen style for the new
> file. I'd still view this as the preferred option, but then all
> aspects should be taken care of. But I won't insist, yet in that
> case clean Linux style is the only other alternative.
Will inherit the style from amd.c in hygon.c.

> > But if you think the conditional should be retained here for some reason
> > (even though the conditional may not be touched), I'll add it.
> See above - yes, I think it should be retained.
Okay, will retain the conditionals.

--
Regards,
Pu Wen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel