[Xen-devel] Suspicious code in p2m_set_altp2m_mem_access

[Alexandru Stefan ISAILA <aisaila@xxxxxxxxxxxxxxx>]

Hi all,

I came across some code in the p2m_set_altp2m_mem_access() that does not 
seem right. On the invalid mfn branch there is a try to set_entry() and 
if that is not successful then the function does not return and calls 
set_entry again for PAGE_ORDER_4K even if there was a check that page 
order is different from PAGE_ORDER_4K.

http://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=xen/arch/x86/mm/mem_access.c;h=a144bb0ce494318b0493dcff31bb5e4e8a742969;hb=refs/heads/staging#l272

Is this behavior wanted?

Regards,
Alex
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel