Re: [Xen-devel] [PATCH v2 11/14] x86/domctl: Add Hygon Dhyana support

[Pu Wen <puwen@xxxxxxxx>]

On 2019/3/15 21:29, Jan Beulich wrote:
> > > > On 21.02.19 at 10:53, <puwen@xxxxxxxx> wrote:
> > Add Hygon Dhyana support to update cpuid info for creating PV guest.
> >
> > Signed-off-by: Pu Wen <puwen@xxxxxxxx>
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> with one remark:
>
> > @@ -281,8 +283,12 @@ static int update_domain_cpuid_info(struct domain *d,
> >               if ( cpu_has_cmp_legacy )
> >                   ecx |= cpufeat_mask(X86_FEATURE_CMP_LEGACY);
> >   
> > -            /* If not emulating AMD, clear the duplicated features in e1d. */
> > -            if ( p->x86_vendor != X86_VENDOR_AMD )
> > +            /*
> > +             * If not emulating AMD and Hygon, clear the duplicated features
> > +             * in e1d.
> I think this wants to be "or" instead of "and".
Yes, will change to "or".

--
Regards,
Pu Wen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel