Re: [Xen-devel] [PATCH] xen: drop the nop() macro

[Julien Grall <julien.grall@xxxxxxx>]

Hi Andrew,

On 15/03/2019 13:39, Andrew Cooper wrote:
> There isn't a plausible reason to insert nops like this into code.
>
> The sole use is in do_debug_key(), and exists to prevent the compiler
> optimising the tail of the function with 'jmp debugger_trap_fatal'
>
> In practice, a compiler barrier suffices just as well to prevent the tailcall,
> and doesn't involve inserting unnecessary instructions.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Acked-by: Julien Grall <julien.grall@xxxxxxx>

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel