[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 6/7] Arm/atomic: unify generation of u64 read/write functions



Hi,

On 11/03/2019 16:51, Jan Beulich wrote:
By adding another suitable abstracting macro the need for explicit
inline function definitions in the 32-bit case goes away.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
---
The selected name for the new macro (PAIR) is subject to improvement
suggestions.

I don't have a better name.


--- a/xen/include/asm-arm/atomic.h
+++ b/xen/include/asm-arm/atomic.h
@@ -35,42 +35,29 @@ static inline void name(volatile type *a
  }
#if defined (CONFIG_ARM_32)
-#define BYTE(n) #n
-#define WORD(n) #n
+#define BYTE(n)  #n
+#define WORD(n)  #n
+#define DWORD(n) "" #n ",%H" #n
+#define PAIR     "d"

Can you please avoid changes that just help to keep things aligned. This is just making the review a bit more difficult for not real benefits.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.