Re: [Xen-devel] [PATCH 0/2] x86: fix build with gcc9

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 07.03.19 at 12:37, <m.a.young@xxxxxxxxxxxx> wrote:
> On Thu, 7 Mar 2019, Jan Beulich wrote:
> 
>> Several build issues (new warnings, causing the build to fail due to
>> -Werror) have been found. The two changes here address the ones
>> I can actually repro; there are a few more related to
>> -Waddress-of-packed-member which I haven't been able to see
>> myself, and hence for now I'm unable to sort out a proper fix /
>> workaround for them.
> 
> I found issues with -Waddress-of-packed-member in 3 places in Fedora. My 
> (possibly flawed) attempt to fix the gcc9 issues (on 4.11) is at 
> https://src.fedoraproject.org/rpms/xen/blob/master/f/xen.gcc9.fixes.patch 

So here we see how effort gets duplicated: What was found here
internally was never posted. What you've found was also never
posted. Who knows how many more distros carry some for of fix
(or perhaps better workaround) for this. May I ask everyone that
such fixes be posted on xen-devel, even if the quick-and-dirty
solutions may not be what we want to commit? It'll at least allow
everyone to know where the issues are and to think of suitable
code changes.

Also sadly your reply doesn't really help me understand why I'm
not myself seeing those -Waddress-of-packed-member issues.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel