[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/1] tools/ocaml: Dup2 /dev/null to stdin in daemonize()

On 2/27/19 11:46 AM, Andrew Cooper wrote:
On 27/02/2019 10:33, Christian Lindig wrote:
Don't close stdin in daemonize() but dup2 /dev/null instead. This avoids
fd 0 being reused and potentially written to.

Signed-off-by: Christian Lindig <christian.lindig@xxxxxxxxxx>

Possibly worth noting that this fixes a bug whereby /dev/xen/evtchn
reliably gets opened on fd 0.

I can fix the wording up on commit if there are no other concerns.

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, and CC'ing
Juergen for 4.12

Release-acked-by: Juergen Gross <jgross@xxxxxxxx>


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.