[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [RFC PATCH 0/4] Add missing default labels to switch statements

On Mon, 25 Feb 2019, Julien Grall wrote:
> Hi,
> On 2/25/19 9:13 PM, Stefano Stabellini wrote:
> > I think it is fine to exploit compiler specific checks when available.
> > However, I don't think we should make any decisions on code correctness
> > based on the compiler checks that we introduce.
> > 
> > In other words, I think it is a good idea to use -Wswitch-enum if
> > possible, but it is not a reason for not having default labels in place
> > as suggested by 16.4. The code should be as correct and safe as
> > possible, without requiring external compiler-specific checks.
> As I said on an answer to Oleksandr, I am not against of having "default"
> labels as long as they contain sensible actions.


> But this does not really address my point above regarding way to help the
> review. Jan is against -Wswitch-enum, and I can understand his point. So how
> do you deal with missing item?

I wonder if Coverity or PRQA can help with that.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.