[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v10 1/6] xen: introduce ptrdiff_t

>>> On 25.02.19 at 21:50, <sstabellini@xxxxxxxxxx> wrote:
> Introduce the new type "ptrdiff_t" which is defined as the signed
> integer type of the result of subtracting two pointers. Use
> __PTRDIFF_TYPE__ to define it.
> Also, use __UINTPTR_TYPE__ for uintptr_t for consistency.

Please can you not mix adjustments to existing type definitions
into a patch adding a new type? __UINTPTR_TYPE__, as said in
prior discussions and other than __PTRDIFF_TYPE__, is not
provided unconditionally by gcc (and I didn't try to work out the
condition(s) so far), so use of it may introduce a regression
(manifesting as a build failure somewhere). Therefore, if we are
to indeed go this route, we should at least leave ourselves the
option of easily reverting one change without the other.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.