[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH V2 1/3] xen/arm: drivers: scif: Add support for SCIFA compatible UARTs

Hi Oleksandr,

On 2/18/19 8:14 PM, Oleksandr wrote:

On 18.02.19 16:00, Julien Grall wrote:


On 01/02/2019 12:37, Oleksandr Tyshchenko wrote:
From: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>

Extend existing driver to be able to handle SCIFA interface as well.

In general a patch should do only one thing. In this case, this should have been split in 2 patches: one to extend the driver, the second to add support for SCIFA.

Please split the patch accordingly.

Not entirely clear to me how the current patch should be split...

- The first patch will be just a copy of the current patch, but without new compatible string (SCIFA).

Without anything related to SCIFA. This patch would only contain the rework of the code.

- The second patch will add new compatible string.

+ anything related to SCIFA (Macros and the SCIFA element in the array port_params.


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.