[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [linux-3.18 bisection] complete test-amd64-amd64-pair [and 1 more messages]

On Tue, Feb 12, 2019 at 02:54:41PM +0000, Ian Jackson wrote:

7b8052e19304 which is a backport to linux-3.18 of be06998f96ec has
been found by the Xen CI auto-bisector to be responsible for a
regression booting under Xen.

Jan Beulich writes ("Re: [linux-3.18 bisection] complete 
No, I'm not. I've said what I can say in a reply to an earlier bisection
report (from Dec 12th), attached again here for reference.

I missed that.  Thanks.

Jan Beulich writes ("Re: [Xen-devel] [linux-3.18 bisection] complete 
On 12.12.18 at 22:41, <osstest-admin@xxxxxxxxxxxxxx> wrote:
>   Bug is in tree:  linux 
>   Bug introduced:  7b8052e19304865477e03a0047062d977309a22f
>   Bug not present: d255d18a34a8d53ccc4a019dc07e17b6e8cf6bd1
>   Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/131278/
>   commit 7b8052e19304865477e03a0047062d977309a22f
>   Author: Jan Beulich <JBeulich@xxxxxxxx>
>   Date:   Mon Oct 19 04:23:29 2015 -0600
>       igb: fix NULL derefs due to skipped SR-IOV enabling

_Very_ interesting. An over three years old commit was determined
to cause whatever regression it is. But wait - that's the date of the
mainline commit, not that of the backport (which was done a month
ago). I notice that of the two original commits the combination of
which the one here is supposed to fix, only one actually got
backported. Hence I wonder whether backporting the one here
was actually appropriate.

The mainline commit be06998f96ecb93938ad2cce46c4289bf7cf45bc from
October 2015 was backported as
7b8052e19304865477e03a0047062d977309a22f.  You need to look at the
commit date as well as the author date:

  commit 7b8052e19304865477e03a0047062d977309a22f
  Author:     Jan Beulich <JBeulich@xxxxxxxx>
  AuthorDate: Mon Oct 19 04:23:29 2015 -0600
  Commit:     Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
  CommitDate: Sat Nov 10 07:39:21 2018 -0800

Interesting. Could you see if picking ceee3450b3 ("igb: make sure SR-IOV
init uses the right number of queues") on top fixes the issue you're
seeing? If not, we can just revert 7b8052e19304.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.