[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH RFC v2 2/2] x86/emulate: Send vm_event from emulate

>>   /* FPU sub-types which may be requested via ->get_fpu(). */
>>   enum x86_emulate_fpu_type {
>> diff --git a/xen/include/asm-x86/hvm/emulate.h 
>> b/xen/include/asm-x86/hvm/emulate.h
>> index 26a01e83a4..721e175b04 100644
>> --- a/xen/include/asm-x86/hvm/emulate.h
>> +++ b/xen/include/asm-x86/hvm/emulate.h
>> @@ -47,6 +47,7 @@ struct hvm_emulate_ctxt {
>>       uint32_t intr_shadow;
>>       bool_t set_context;
>> +    bool send_event;
> I'm not sure I see why a send_event field needs to be added to the
> ctxt struct, isn't is possible to pass this parameter to the relevant
> functions that care about it?
This was done to have as little code change as possible and it has a 
precedent with the set_context bool. If a send_event parameter would be 
used then it will have to be passed down the line and then a lot of 
function signatures have to change. I think the current way is the best 
way to have this done.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.