[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH RFC v2 1/2] x86/emulate: Move hvmemul_linear_to_phys

On 2/4/19 5:14 PM, Roger Pau Monné wrote:
On Mon, Feb 04, 2019 at 02:00:40PM +0200, Razvan Cojocaru wrote:
On 2/4/19 1:55 PM, Paul Durrant wrote:
-----Original Message-----
From: Alexandru Stefan ISAILA [mailto:aisaila@xxxxxxxxxxxxxxx]
Sent: 04 February 2019 11:37
To: xen-devel@xxxxxxxxxxxxxxxxxxxx
Cc: Paul Durrant <Paul.Durrant@xxxxxxxxxx>; jbeulich@xxxxxxxx; Andrew
Cooper <Andrew.Cooper3@xxxxxxxxxx>; Wei Liu <wei.liu2@xxxxxxxxxx>; Roger
Pau Monne <roger.pau@xxxxxxxxxx>; rcojocaru@xxxxxxxxxxxxxxx;
tamas@xxxxxxxxxxxxx; George Dunlap <George.Dunlap@xxxxxxxxxx>
Subject: Re: [PATCH RFC v2 1/2] x86/emulate: Move hvmemul_linear_to_phys

Ping, any thoughts on this are appreciated.


On 11.01.2019 17:37, Alexandru Stefan ISAILA wrote:
This is done so hvmemul_linear_to_phys() can be called from

I have no objection to pure code movement for this purpose. I certainly prefer 
it to forward declaration of statics.
Thanks for the reply!

We're also after thoughts on the whole series (replying to this specific
patch instead of the cover letter was an accident).

We expect the second patch to be more controversial and in some need of
detailed scrutiny.

I've taken a look at patch 2 and provided some review comments, sorry
for the delay. Keep in mind we are in the middle of the release
process and most developers and reviewers are busy trying to fix bugs
or reviewing bugfixes.

Very much appreciated!


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.