[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 for-4.12] gic-vgic: fix an assert condition



Hi,

On 28/01/2019 12:04, Juergen Gross wrote:
On 25/01/2019 18:06, Andrii Anisov wrote:
From: Andrii Anisov <andrii_anisov@xxxxxxxx>

Currently, that assert condition does not correspond to a comment above
and makes assertion failed on HW IRQ disconnection.
Fix the condition so it corresponds to the comment and allows IRQ
disconnection on debug builds.

Fixes: ec2a2f1 ("ARM: VGIC: factor out vgic_connect_hw_irq()")
Signed-off-by: Andrii Anisov <andrii_anisov@xxxxxxxx>
Suggested-by: Stefan Nuernberger <snu@xxxxxxxxx>

Release-acked-by: Juergen Gross <jgross@xxxxxxxx>

Thank you!

I have now applied the patch with a slight reword in the commit message:

xen/arm: gic-vgic: fix assert condition in vgic_connect_hw_irq

Currently, the assert condition in vgic_connect_hw_irq does not correspond to
the comment above and result to hit the assertion on HW IRQ disconnection.
Fix the condition so it corresponds to the comment and allows IRQ
disconnection on debug builds.

Andrii, please try to add the subsystem you modify in the commit title (i.e xen/arm). This helps for the reviewer to know what you are modifying and also helps when looking at shortlog.

Cheers,



Juergen


--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.