[Xen-devel] [OSSTEST PATCH 20/26] power: Use `Combined' as Name for PDU+ILOM approach

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
---
 Osstest/TestSupport.pm | 11 +++++++----
 mg-hosts               |  2 +-
 2 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
index 886e95d4..fb14c4b3 100644
--- a/Osstest/TestSupport.pm
+++ b/Osstest/TestSupport.pm
@@ -938,9 +938,10 @@ sub power_cycle_host_setup ($) {
     # $ho->{PowerApproaches}[]{Name}        see below
     # $ho->{PowerApproaches}[]{MethObjs}[]  each has ->pdu_power_state($on)
     # `Name's are:
-    #    Only   Host only supports one method and this is it
-    #    ILOM   Try to use just the ILOM
-    #    PDU    Try to use the PDU (but also turn off/on ILOM if provided)
+    #    Only     Host only supports one method and this is it
+    #    ILOM     Try to use just the ILOM
+    #    PDU      Try to use the PDU (no ILOM provided)
+    #    Combined Try to use the PDU and ILOM tohether
     my @approaches;
     my $pdu_s = get_host_property($ho,'PowerPDU');
     my $ilom_s = get_host_property($ho,'PowerILOM');
@@ -955,8 +956,10 @@ sub power_cycle_host_setup ($) {
        }
        if ($pdu_s) {
            my $pdu_m = power_cycle_parse_method($ho, $pdu_s);
+           my $pdu_name = 'PDU';
            if ($ilom_m) {
                require Osstest::PDU::try_off;
+               $pdu_name = 'Combined';
                $pdu_m = [
                    @$pdu_m,
                    get_host_method_object($ho, 'PDU', 'pause'),
@@ -964,7 +967,7 @@ sub power_cycle_host_setup ($) {
                ];
            }
            push @approaches, {
-               Name => 'PDU',
+               Name => $pdu_name,
                MethObjs => ['nest', @$pdu_m ],
            };
        }
diff --git a/mg-hosts b/mg-hosts
index 2edf1216..58b4acc3 100755
--- a/mg-hosts
+++ b/mg-hosts
@@ -31,7 +31,7 @@
 #                "1" or "off"   : power off
 #                "c" or "r"     : reboot
 #               APPROACH_RE is a regexp specifying which method to
-#               use.  Methods are:  Only ILOM PDU SSH
+#               use.  Methods are:  Only Combined ILOM PDU SSH
 #               and the lightest method which matches will be used.
 #               If not specified, the most reliable method will be used.
 #
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel