Re: [Xen-devel] [PATCH for-4.12 2/8] xen/arm: p2m: Provide an helper to generate the VTTBR

[Julien Grall <julien.grall@xxxxxxx>]

Hi Stefano,

On 23/01/2019 23:27, Stefano Stabellini wrote:
> On Wed, 28 Nov 2018, Julien Grall wrote:
> > A follow-up patch will need to generate the VTTBR in a few places.
> >
> > Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
> > ---
> >   xen/arch/arm/p2m.c | 7 ++++++-
> >   1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
> > index 6c76298ebc..8ebf1e8dba 100644
> > --- a/xen/arch/arm/p2m.c
> > +++ b/xen/arch/arm/p2m.c
> > @@ -47,6 +47,11 @@ static const paddr_t level_masks[] =
> >   static const uint8_t level_orders[] =
> >       { ZEROETH_ORDER, FIRST_ORDER, SECOND_ORDER, THIRD_ORDER };
> >   
> > +static uint64_t generate_vttbr(uint16_t vmid, mfn_t root_mfn)
> > +{
> > +    return (mfn_to_maddr(root_mfn) | ((uint64_t)vmid << 48));
> Outer brackets are not necessary. Regardless:
I would prefer to keep them here.

> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
Thank you!

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel