Re: [Xen-devel] [PATCH 0/2] Dangling fixes for ARM iommu

[Andrii Anisov <andrii.anisov@xxxxxxxxx>]

Hello Julien,

On 22.01.19 16:31, Julien Grall wrote:
> > IMO, the pure fixes, like patch 2, and the first hunk of patch 1 should be OK 
> > for 4.12.
> The first hunk of patch 1 aside, we never supported the new IOMMU bindings nor 
> unsharing the P2M. So what do you actually fix?
>
> Supporting unshared P2M will require more work given because the code relies on 
> mfn_to_gmfn that is not implemented on Arm. So accepting this patch standalone 
> would be misleading as the rest of the series is not going to be merged in Xen 
> 4.12.
I'm not saying I want something from non-shared p2m push into 4.12.
I would strip the first patch to its first chunk.

> Similarly, we don't support new IOMMU bindings. The patch #2 alone is going to 
> add more trouble as now Dom0 would not be able to use the IOMMU if it were not 
> hidden.
Are you sure we should pass IOMMU devices or related info to Dom0 if they are 
not supported by hypervisor?
The commit message states "We don't passthrough IOMMU device to DOM0 even if it is 
not used by Xen.", and you agreed that some time ago. Could you please clarify why 
you have changed your mind?

--
Sincerely,
Andrii Anisov.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel