[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] iommu: Eliminate an odd local variable



Hello Jan,

On 22.01.19 10:20, Jan Beulich wrote:
What's excessive there? How come you alter the function's
return value without saying why? The more that you make
it potentially return success when there was an error.

Ah, I've realized the difference. In unmap, for hardware domain, we will 
iterate through pages even if some page failed to unmap, preserving the first 
caught error.
So my patch is wrong.

Sorry for disturbing.

--
Sincerely,
Andrii Anisov.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.