Re: [Xen-devel] Xen-unstable PVHdom0: Assertion 'IS_ALIGNED(dfn_x(dfn), (1ul << page_order))' failed at iommu.c:324

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Fri, Jan 18, 2019 at 01:03:04PM +0100, Sander Eikelenboom wrote:
> Hi Roger,
> 
> I gave PVH dom0 a spin, see how far I would get.

Thanks!

> With current xen-unstable unfortunately not that far, i got the splat below.

Yes, this was already reported:

https://lists.xenproject.org/archives/html/xen-devel/2019-01/msg01030.html

> If you need more info, would like me to test a patch (or some other git 
> tree/branch), 
> I will be happy to give it a spin !

Paul is working on a fix, but in the meantime just removing the
assertions should be fine:

---8<---
diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c
index bd1af35a13..98e6fc35e2 100644
--- a/xen/drivers/passthrough/iommu.c
+++ b/xen/drivers/passthrough/iommu.c
@@ -321,9 +321,6 @@ int iommu_map(struct domain *d, dfn_t dfn, mfn_t mfn,
     if ( !iommu_enabled || !hd->platform_ops )
         return 0;
 
-    ASSERT(IS_ALIGNED(dfn_x(dfn), (1ul << page_order)));
-    ASSERT(IS_ALIGNED(mfn_x(mfn), (1ul << page_order)));
-
     for ( i = 0; i < (1ul << page_order); i++ )
     {
         rc = hd->platform_ops->map_page(d, dfn_add(dfn, i), mfn_add(mfn, i),


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel