Re: [Xen-devel] [PATCH RFC for next] xen: make grant table configurable

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Jan 17, 2019 at 08:19:28PM +0000, Andrew Cooper wrote:
> On 17/01/2019 12:30, Wei Liu wrote:
> > Introduce CONFIG_GRANT_TABLE. Provide stubs and make sure x86 and arm
> > hypervisors build with grant table disabled.
> >
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > ---
> > I did this when I worked on splitting PV and HVM and thought this
> > might be useful and it was simple enough to get done.
> >
> > RFC because I can envisage some configurations in the distant future
> > do away with grant table and event channel. There is small a benefit
> > to consider accepting this patch now so that Gitlab's randconf build
> > can start testing with grant table turned off right away.
> > ---
> >  xen/arch/arm/setup.c              |  3 ++-
> >  xen/arch/arm/traps.c              |  2 ++
> >  xen/arch/x86/hvm/Makefile         |  2 +-
> >  xen/arch/x86/hvm/hypercall.c      |  4 ++++
> >  xen/arch/x86/hypercall.c          |  2 ++
> >  xen/arch/x86/pv/Makefile          |  2 +-
> >  xen/arch/x86/pv/hypercall.c       |  2 ++
> >  xen/arch/x86/setup.c              |  6 +++--
> >  xen/common/Kconfig                | 11 +++++++++
> >  xen/common/Makefile               |  2 +-
> >  xen/include/asm-arm/grant_table.h |  4 +++-
> >  xen/include/xen/grant_table.h     | 49 
> > +++++++++++++++++++++++++++++++++++++--
> >  12 files changed, 80 insertions(+), 9 deletions(-)
> >
> > diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
> > index 444857a967..3cd3513928 100644
> > --- a/xen/arch/arm/setup.c
> > +++ b/xen/arch/arm/setup.c
> > @@ -740,7 +740,8 @@ void __init start_xen(unsigned long boot_phys_offset,
> >          .flags = XEN_DOMCTL_CDF_hvm_guest | XEN_DOMCTL_CDF_hap,
> >          .max_evtchn_port = -1,
> >          .max_grant_frames = gnttab_dom0_frames(),
> > -        .max_maptrack_frames = opt_max_maptrack_frames,
> > +        .max_maptrack_frames = IS_ENABLED(CONFIG_GRANT_TABLE) ?
> > +                               opt_max_maptrack_frames : 0,
> 
> You can remove this conditional logic by adding #define
> opt_max_grant_frames 0 in the stubs in grant_table.h
> 

Ack.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel