Re: [Xen-devel] [PATCH 1/3] string: avoid undefined behavior in strrchr()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 07.01.19 at 10:49, <jgross@xxxxxxxx> wrote:
> On 07/01/2019 10:39, Jan Beulich wrote:
>> The pre-decrement would not only cause misbehavior when wrapping (benign
>> because there shouldn't be any NULL pointers passed in), but may also
>> create a pointer pointing outside the object that the passed in pointer
>> points to (it won't be de-referenced though). Use post-decrement (and >
>> instead of >= ) instead.
> 
> This commit message doesn't match the patch. There is no post-decrement
> and '>' involved.

Oh, indeed, that was stale from a first attempt, until I realized that
the post-decrement would make things only marginally better. I've
simply dropped that sentence.

> With that fixed you can add:
> 
> Reviewed-by: Juergen Gross <jgross@xxxxxxxx>

Thanks, Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel