Re: [Xen-devel] [PATCH XTF v2 4/4] xtf: Add monitor mem_access test

[Petre Ovidiu PIRCALABU <ppircalabu@xxxxxxxxxxxxxxx>]

On Wed, 2019-01-02 at 07:27 -0700, Tamas K Lengyel wrote:
> > +static int mem_access_init()
> > +{
> > +    int rc = 0;
> > +    mem_access_monitor_t *pmon = (mem_access_monitor_t *)monitor;
> > +
> > +    if ( !pmon )
> > +        return -EINVAL;
> > +
> > +    rc = xc_domain_set_access_required(monitor->xch, monitor-
> > >domain_id, 1);
> > +    if ( rc < 0 )
> > +    {
> > +        XTF_MON_ERROR("Error %d setting mem_access listener
> > required\n", rc);
> > +        return rc;
> > +    }
> > +
> > +    pmon->gfn = xc_translate_foreign_address(monitor->xch,
> > monitor->domain_id,
> > +                                             0, pmon->address);
> 
> Check that the gfn returned is not 0 before continuing.

I will correct it in the next iteration.
Thanks for noticing it,
Petre


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel