Re: [Xen-devel] [PATCH v2 2/2] x86/dom0: add verbose mode and print memory allocation stats

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Wed, Jan 02, 2019 at 12:35:17PM +0000, Wei Liu wrote:
> On Fri, Dec 28, 2018 at 12:18:57PM +0100, Roger Pau Monne wrote:
> > Add a verbose option to the dom0 command line, so that dom0 builder
> > can print extra debug information when required.
> > 
> > Use this new verbose mode to print statistics about memory allocations
> > when populating dom0 p2m.
> > 
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > ---
> > Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
> > Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > Cc: Jan Beulich <jbeulich@xxxxxxxx>
> > Cc: Julien Grall <julien.grall@xxxxxxx>
> > Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> > Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> > Cc: Tim Deegan <tim@xxxxxxx>
> > Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> > ---
> >  docs/misc/xen-command-line.markdown |  8 +++++++-
> >  xen/arch/x86/dom0_build.c           |  3 +++
> >  xen/arch/x86/hvm/dom0_build.c       | 16 ++++++++++++++++
> >  xen/include/asm-x86/setup.h         |  1 +
> >  4 files changed, 27 insertions(+), 1 deletion(-)
> > 
> > diff --git a/docs/misc/xen-command-line.markdown 
> > b/docs/misc/xen-command-line.markdown
> > index 78b207c0d0..e7973ee509 100644
> > --- a/docs/misc/xen-command-line.markdown
> > +++ b/docs/misc/xen-command-line.markdown
> > @@ -637,7 +637,7 @@ trace feature is only enabled in debugging builds of 
> > Xen.
> >  Specify the bit width of the DMA heap.
> >  
> >  ### dom0 (x86)
> > -> `= List of [ pvh | shadow ]`
> > +> `= List of [ pvh | shadow | verbose ]`
> >  
> >  > Sub-options:
> >  
> > @@ -654,6 +654,12 @@ Flag that makes a dom0 boot in PVHv2 mode.
> >  Flag that makes a dom0 use shadow paging. Only works when "pvh" is
> >  enabled.
> >  
> > +> `verbose`
> > +
> > +> Default: `false`
> > +
> > +Print debug information during dom0 build.
> > +
> 
> Is there plan to expand this to PV as well? A user reading this may
> specify dom0=verbose in a PV setup but find nothing in the log.

Dom0 PV build is already quite verbose in comparison to PVH. The only
user ATM is indeed PVH Dom0 builder, but it could be used by PV also.

I could add something to the documentation, but I'm afraid it would
get stale.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel