Re: [Xen-devel] [PATCH] gic-vgic: skip irqs locking in gic_restore_pending_irqs()

[Julien Grall <julien.grall@xxxxxxxxx>]

Hi,

Sorry for the formatting.

Please address my comments from the previous version.

Cheers,

On Fri, 21 Dec 2018, 18:18 Andrii Anisov, <andrii.anisov@xxxxxxxxx> wrote:

From: Andrii Anisov <andrii_anisov@xxxxxxxx>

This function is called under IRQs disabled already, so drop additional
flags save and restore.

Signed-off-by: Andrii Anisov <andrii_anisov@xxxxxxxx>

---

This is a half of an RFC patch [1] which relies on the already
existing code.

[1] https://lists.xenproject.org/archives/html/xen-devel/2018-11/msg03293.html

---
 xen/arch/arm/gic-vgic.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/xen/arch/arm/gic-vgic.c b/xen/arch/arm/gic-vgic.c
index 48922f5..34179c0 100644
--- a/xen/arch/arm/gic-vgic.c
+++ b/xen/arch/arm/gic-vgic.c
@@ -279,11 +279,10 @@ static void gic_restore_pending_irqs(struct vcpu *v)
     int lr = 0;
     struct pending_irq *p, *t, *p_r;
     struct list_head *inflight_r;
-    unsigned long flags;
     unsigned int nr_lrs = gic_get_nr_lrs();
     int lrs = nr_lrs;

-    spin_lock_irqsave(&v->arch.vgic.lock, flags);
+    spin_lock(&v->arch.vgic.lock);

     if ( list_empty(&v->arch.vgic.lr_pending) )
         goto out;
@@ -327,7 +326,7 @@ found:
     }

 out:
-    spin_unlock_irqrestore(&v->arch.vgic.lock, flags);
+    spin_unlock(&v->arch.vgic.lock);
 }

 void gic_clear_pending_irqs(struct vcpu *v)
--
2.7.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel