Re: [Xen-devel] [PATCH v6.1 09/20] xen: add basic hooks for PVH in current code

[Daniel Kiper <daniel.kiper@xxxxxxxxxx>]

On Fri, Dec 07, 2018 at 08:35:26AM +0100, Juergen Gross wrote:
> Add the hooks to current code needed for Xen PVH. They will be filled
> with code later when the related functionality is being added.
>
> loader/i386/linux.c needs to include machine/kernel.h now as it needs
> to get GRUB_KERNEL_USE_RSDP_ADDR from there. This in turn requires to
> add an empty kernel.h header for some i386 platforms (efi, coreboot,
> ieee1275, xen).
>
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> Reviewed-by: Daniel Kiper <daniel.kiper@xxxxxxxxxx>
> ---
> V3: xenpvh->xen_pvh (Daniel Kiper)
>     adjust copyright date (Roger Pau Monné)
> V5: update commit message (Daniel Kiper)
>     move including xen/hvm/start_info.h to the sources really needing
>       it (Daniel Kiper)
> V6.1: add empty kernel.h headers for i386 platforms

After this patch "xen_pvh: add build runes for grub-core" does not apply
any longer. May I ask you to rebase whole patch series on latest master
and resend it as v7?

>     It should be noted that i386_efi build is broken even without this
>     patch, but this is clearly beyond the scope of this series.

Could you tell me how exactly building fails?

Have you tested x86_64 efi and xen builds?

Daniel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel