Re: [Xen-devel] [xen-unstable test] 130858: regressions - FAIL

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Dec 03, 2018 at 05:28:08AM -0700, Jan Beulich wrote:
> >>> On 03.12.18 at 12:57, <wei.liu2@xxxxxxxxxx> wrote:
> > On Mon, Dec 03, 2018 at 02:49:34AM -0700, Jan Beulich wrote:
> >> >>> On 01.12.18 at 13:43, <osstest-admin@xxxxxxxxxxxxxx> wrote:
> >> > flight 130858 xen-unstable real [real]
> >> > http://logs.test-lab.xenproject.org/osstest/logs/130858/ 
> >> > 
> >> > Regressions :-(
> >> > 
> >> > Tests which did not succeed and are blocking,
> >> > including tests which could not be run:
> >> >  build-amd64                   6 xen-build                fail REGR. vs. 
> >> > 129817
> >> 
> >> In sequence (from the make log) there is 
> >> 
> >> mkdir -p xen-root
> >> rm -f linkfarm.stamp.tmp
> >> set -e; \
> >>  (mkdir -p xen-root/config; cd xen-root/config; find 
> >> /home/osstest/build.130858.build-amd64/xen/tools/firmware/xen-dir/../../../config/
> >>  -type d | sed 
> > 's,^/home/osstest/build.130858.build-amd64/xen/tools/firmware/xen-dir/../../../config/,,g'
> >  | xargs mkdir -p .);  (mkdir -p xen-root/xen; cd xen-root/xen; find 
> > /home/osstest/build.130858.build-amd64/xen/tools/firmware/xen-dir/../../../xen/
> >  -type d | sed 
> > 's,^/home/osstest/build.130858.build-amd64/xen/tools/firmware/xen-dir/../../../xen/,,g'
> >  | xargs mkdir -p .); \
> >>  (cd 
> > /home/osstest/build.130858.build-amd64/xen/tools/firmware/xen-dir/../../..; 
> > find config ! -type l -type f ! -name '*.[isoa]' ! -name '.*.d' ! -name 
> > '.*.d2') >> linkfarm.stamp.tmp ;   (cd 
> > /home/osstest/build.130858.build-amd64/xen/tools/firmware/xen-dir/../../..; 
> > find xen ! -type l -type f ! -name '*.[isoa]' ! -name '.*.d' ! -name 
> > '.*.d2') >> linkfarm.stamp.tmp ;  \
> >>  echo Config.mk >> linkfarm.stamp.tmp ;
> >> 
> >> (i.e. a piece of the shim build process)
> >> 
> >> configure: loading cache ../.././config.cache
> >> checking build system type... (cached) x86_64-unknown-linux-gnu
> >> checking for a BSD-compatible install... /usr/bin/install -c
> >> checking whether build environment is sane...
> >> 
> >> (unrelated)
> >> 
> >> rm -f /home/osstest/build.130858.build-amd64/xen/xen/.xen-syms.[0-9]*
> >> 
> >> (i.e. a piece of the main hypervisor build process afaict)
> >> 
> >> find: 
> >> `/home/osstest/build.130858.build-amd64/xen/tools/firmware/xen-dir/../../../xen/.xen-syms.0':
> >>  No such file or directory
> >> find: `xen/.xen-syms.1.S': No such file or directory
> >> find: `xen/.xen-syms.1.S': No such file or directory
> >> 
> >> (i.e. a portion of the execution of above shim build step)
> >> 
> >> I think this points out a race between the main hypervisor build
> >> and the shim part of the tools build, due to find (obviously) not
> >> being an atomic operation, resulting in the intermediate
> >> .xen-syms.[0-9]* files first being found, but then being
> >> unavailable for find's stat() or whatever invocation. Depending
> >> on the internal workings of find, adding the pattern to the
> >> exclusion list may or may not help (and whether it does may
> >> then also vary per build platform).
> > 
> > Why do you think adding the new pattern will not work all the time? Even
> > if find isn't atomic, I think adding the new pattern will make it omit
> > those files even if they show up while find is running.
> 
> Is it well defined that -name gets evaluated before -type? Is it
> well defined at all in what order primaries get evaluated? If an
> implementation issued stat() (or whatever variant of it) before
> applying -name filtering, the error would still surface.

OK. I see what you mean.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel