[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 18/18] xen/arm: Suspend/resume console on Xen suspend/resume



Hi Mirela,

On 11/12/18 11:30 AM, Mirela Simonovic wrote:
This is done using generic console_suspend/resume functions that cause
uart driver specific suspend/resume handlers to be called for each
initialized port (if the port has suspend/resume driver handlers
implemented).

Signed-off-by: Mirela Simonovic <mirela.simonovic@xxxxxxxxxx>
Signed-off-by: Saeed Nowshadi <saeed.nowshadi@xxxxxxxxxx>
---
  xen/arch/arm/suspend.c | 14 ++++++++++++++
  1 file changed, 14 insertions(+)

diff --git a/xen/arch/arm/suspend.c b/xen/arch/arm/suspend.c
index a05aea9c25..6d7d69539b 100644
--- a/xen/arch/arm/suspend.c
+++ b/xen/arch/arm/suspend.c
@@ -1,5 +1,6 @@
  #include <xen/sched.h>
  #include <xen/cpu.h>
+#include <xen/console.h>
  #include <asm/cpufeature.h>
  #include <asm/event.h>
  #include <asm/psci.h>
@@ -149,6 +150,15 @@ static long system_suspend(void *data)
          goto resume_irqs;
      }
+ dprintk(XENLOG_DEBUG, "Suspend\n");

This message may not appear on the console unless it is synchronized (see console_start_sync). Also, it might be a useful message in non-debug build.

Ideally the suspend/resume logic should not be much different than x86 (see arch/x86/acpi/power.c).

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.