Re: [Xen-devel] [PATCH] xen/tools: Fix gen-cpuid.py's ability to report errors

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 26.11.18 at 13:17, <wei.liu2@xxxxxxxxxx> wrote:
> On Mon, Nov 26, 2018 at 12:03:07PM +0000, Andrew Cooper wrote:
>> c/s 18596903 "xen/tools: support Python 2 and Python 3" unfortunately
>> introduced a TypeError when changing how Fail exceptions were printed:
>> 
>>   /local/xen.git/xen/../xen/tools/gen-cpuid.py:Traceback (most recent call 
>> last):
>>     File "/local/xen.git/xen/../xen/tools/gen-cpuid.py", line 483, in 
>> <module>
>>         sys.stderr.write(e)
>>   TypeError: expected a character buffer object
>> 
>> Coerce e to a string before printing.  While changing this, fold the three
>> write() calls making up the line into a single one, and take the opportunity
>> to neaten the output.
>> 
>> A sample error is:
>> 
>>   /local/xen.git/xen/tools/gen-cpuid.py: Fail: Aliased value between FOO and 
>> BAR
>> 
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> 
> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel