Re: [Xen-devel] [PATCH v5 6/6] amd/iommu: skip bridge devices when updating IOMMU page tables

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Thu, Nov 22, 2018 at 06:20:46AM -0700, Jan Beulich wrote:
> >>> On 22.11.18 at 13:47, <roger.pau@xxxxxxxxxx> wrote:
> > I think the is_hardware_domain part can be dropped from the
> > conditional I'm adding. update_paging_mode shouldn't be used to decide
> > whether a domain can or cannot have bridges attached. Whether a DomU
> > can or cannot have a host bridge assigned should be decided at
> > assignation time, and hence update_paging_mode shouldn't have hardware
> > domain specific checks.
> 
> Okay, we're in agreement then.
> 
> > Regarding the check in amd_iommu_add_device, if it's removed from
> > there amd_iommu_add_device would return an error when adding a host
> > bridge device, and that would cause setup_one_hwdom_device to return
> > early and not setup vPCI handlers for host bridges, so I think we want
> > to leave that one as-is.
> 
> Right, I can see why it may be better to retain it there.

Thanks. Would you like me to resend the series with this fix, or
should I wait for feedback on the remaining patches?

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel